DataGrid - Fix the "No data" text not being shown when a lookup column is filtered (T1293839) by markallenramirez · Pull Request #32757 · DevExpress/DevExtreme

markallenramirez · 2026-03-03T10:01:48Z

No description provided.

Copilot

Pull request overview

Adds an E2E regression test to ensure DataGrid renders the “No data” text after filtering a lookup column, covering the scenario described in the PR title.

Changes:

Import List TestCafe model to interact with the lookup dropdown.
Add a new screenshot-based TestCafe test reproducing “lookup filter + text filter => no data” state.

e2e/testcafe-devextreme/tests/dataGrid/common/markup/noDataText.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

packages/devextreme/js/__internal/grids/grid_core/m_utils.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

packages/devextreme/js/__internal/grids/grid_core/views/m_rows_view.ts

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/m_utils.ts

e2e/testcafe-devextreme/tests/dataGrid/common/markup/noDataText.ts

Alyar666 · 2026-03-06T13:09:36Z

e2e/testcafe-devextreme/tests/dataGrid/common/markup/noDataText.ts

+
+  // act
+  await t.click(lookupFilterCell.element);
+  const lookupList = new List(OVERLAY_SELECTOR);


Minor comment: I suggest creating a getLookup/getSelectBox method at the FilterCell model level, which will return the SelectBox model. This model has the necessary API for testing.

Instead of creating another method, I refactored FilterCell and related DataGrid methods.

Before:
DataGrid.getFilterRow returns Selector
DataGrid.getFilterCell returns Selector
filterTextBox extends an editor and exposes a filter cell's filter operations menu
DataGrid.getFilterEditor returns EditorType, but based only on defined filter editors (currently only filterTextBox exists)

After:
DataGrid.getFilterRow returns FilterRow (now use filterRow.element to get element Selector)
DataGrid.getFilterCell returns FilterCell (now use filterRow.element to get element Selector)
FilterCell exposes a filter cell's filter operations menu
DataGrid.getFilterEditor can now accept any base editor type (e.g., TextBox, SelectBox, etc.)

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-09T09:52:31Z

...stcafe-devextreme/tests/dataGrid/common/filterRow/T1163100_changeFIlterIcon.visual_matrix.ts

          await t
-            .click(filterMenu.menuButton())
-            .click(filterMenu.menu.getItemByText('Starts with'));
+            .click(filterCell.menuButton())


FilterCell.menuButton is a Selector property, but this test calls it as a function (menuButton()). This will either fail TypeScript compilation or pass a NodeSnapshot/promise to t.click, depending on typings, and is inconsistent with the other updated tests. Use the selector property directly (no parentheses).

Suggested change

.click(filterCell.menuButton())

.click(filterCell.menuButton)

This reverts commit 9ffb359.

This reverts commit b7836c1.

This reverts commit 9a233a7.

This reverts commit e66ecca.

markallenramirez self-assigned this Mar 3, 2026

Copilot AI review requested due to automatic review settings March 3, 2026 10:01

markallenramirez requested a review from a team as a code owner March 3, 2026 10:01

markallenramirez added the 26_1 label Mar 3, 2026

Copilot started reviewing on behalf of markallenramirez March 3, 2026 10:02 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

markallenramirez changed the title ~~DataGrid - Fix the "No data" text not being shown when a lookup column is filtered~~ DataGrid - Fix the "No data" text not being shown when a lookup column is filtered (T1293839) Mar 3, 2026

Copilot AI review requested due to automatic review settings March 3, 2026 11:53

Copilot started reviewing on behalf of markallenramirez March 3, 2026 11:54 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/m_utils.ts Outdated Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/m_utils.ts Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 4, 2026 12:35

Copilot started reviewing on behalf of markallenramirez March 4, 2026 12:35 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 5, 2026 08:15

markallenramirez force-pushed the bug_T1293839/26_1 branch from 7696eba to e66ecca Compare March 5, 2026 08:15

Copilot started reviewing on behalf of markallenramirez March 5, 2026 08:16 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Alyar666 requested changes Mar 6, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/views/m_rows_view.ts Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 6, 2026 12:04

Copilot started reviewing on behalf of markallenramirez March 6, 2026 12:05 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/m_utils.ts Show resolved Hide resolved

Alyar666 requested changes Mar 6, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 9, 2026 09:45

Copilot started reviewing on behalf of markallenramirez March 9, 2026 09:47 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

markallenramirez added 5 commits March 9, 2026 20:20

test

3e3a12f

update test

1c7ae24

fix

22c79ee

update test

d54ed8c

etalon

80d1c85

markallenramirez added 13 commits March 9, 2026 20:20

update fix

ecb098a

Revert "update fix"

72fd464

This reverts commit 9ffb359.

fix

58ec07b

Revert "fix"

9b955ef

This reverts commit b7836c1.

Revert "fix"

2dd1946

This reverts commit 9a233a7.

fix

41add33

Revert "fix"

824fa7a

This reverts commit e66ecca.

fix

c27a8f3

fix

696541a

test await grid ready

ffc61a5

refactor

e5d448b

refactor noData test

65697b0

refactor treelist

879e6f0

markallenramirez force-pushed the bug_T1293839/26_1 branch from 1bed5b3 to 879e6f0 Compare March 9, 2026 12:20

	.click(filterCell.menuButton())
	.click(filterCell.menuButton)

Conversation

markallenramirez commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Alyar666 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

markallenramirez Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants